Statelessnet-only: Move versions 68 and 69 back to 80 and 81. #11719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tayfunelmas
requested review from
Longarithm,
wacban and
a team
and removed request for
a team
wacban
reviewed
Jul 4, 2024
wacban
approved these changes
Jul 4, 2024
|
btw if you are close to fixing that genesis congestion info bootstrapping it may be easier to just patch that |
I do not think that will help because it will only work if the bootstrapping happens and saved to DB at the very beginning. For statelessnet, we already passed that point (state roots are already garbage collected). |
|
I am closing this since the failing integration tests are complicating the situation and it is risky to merge this. Instead I will send a simpler PR. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 5, 2024
#11727) This is a mitigation for the failure that is caused by the stabilization PR #11701. [Zulip thread](https://near.zulipchat.com/#narrow/stream/308695-nearone.2Fprivate/topic/Cherrypicks.20to.20statelessnet.20branch/near/449016937) Context: In statelessnet, the genesis version is above 68, so it assumes that genesis has the congestion control is enabled and hitting an issue that attempts to bootstrap congestion info (again) and hitting missing state roots. We attempted to move the version numbers for congestion control and stateless validation back to 80 and 81 to mitigate the problem, [in this PR](#11719) but it became unnecessarily complex and risky. Thus, in this PR, we simply bypass the problematic bootstrap for statelessnet only. We moved the check for the chain id after the genesis protocol version check so we will not run it for testnet and mainnet.
tayfunelmas
added a commit
that referenced
this pull request
Jul 5, 2024
#11727) This is a mitigation for the failure that is caused by the stabilization PR #11701. [Zulip thread](https://near.zulipchat.com/#narrow/stream/308695-nearone.2Fprivate/topic/Cherrypicks.20to.20statelessnet.20branch/near/449016937) Context: In statelessnet, the genesis version is above 68, so it assumes that genesis has the congestion control is enabled and hitting an issue that attempts to bootstrap congestion info (again) and hitting missing state roots. We attempted to move the version numbers for congestion control and stateless validation back to 80 and 81 to mitigate the problem, [in this PR](#11719) but it became unnecessarily complex and risky. Thus, in this PR, we simply bypass the problematic bootstrap for statelessnet only. We moved the check for the chain id after the genesis protocol version check so we will not run it for testnet and mainnet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of the stabilization PR #11701.
In statelessnet, the genesis version is above 68, so it assumes that genesis has the congestion control is enabled and hitting an issue that attempts to bootstap congestion info (again) and hitting missing state roots.
This change moves the version numbers for congestion control and stateless validation back to 80 and 81 to mitigate the problem. Only merging to statelessnet_master. This should not be merged to mainnet/testnet.